Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add Github labels based on PR title #2914

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

mdelapenya
Copy link
Member

  • chore: add security as valid convention PR title
  • chore: add labels based on PR title

What does this PR do?

It activates the autolabeler feature from the release-drafter Github Action, adding labels based on the PR title.

This is now possible thanks to the enforcement of conventional commits in the PR title.

Why is it important?

It will simplify the burden of adding labels to PRs, making the creation of the release notes easier: as PRs will be automatically labelled, they will land into the right release notes section properly.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner December 10, 2024 10:32
@mdelapenya mdelapenya self-assigned this Dec 10, 2024
@mdelapenya mdelapenya requested a review from stevenh December 10, 2024 10:32
Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit c09bd41
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/675934c3d33af100082a3763
😎 Deploy Preview https://deploy-preview-2914--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues with the patterns, to match conventional commit standard.

.github/release-drafter.yml Outdated Show resolved Hide resolved
.github/release-drafter.yml Outdated Show resolved Hide resolved
@mdelapenya mdelapenya requested a review from stevenh December 10, 2024 13:10
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed a few

.github/release-drafter.yml Outdated Show resolved Hide resolved
.github/release-drafter.yml Outdated Show resolved Hide resolved
@mdelapenya mdelapenya requested a review from stevenh December 10, 2024 16:59
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the docs which still mention break type instead of exclamation mark / BREAKING CHANGE: footer.

docs/contributing.md Outdated Show resolved Hide resolved
@mdelapenya mdelapenya requested a review from stevenh December 11, 2024 07:15
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Dec 11, 2024
@mdelapenya mdelapenya merged commit ac61579 into testcontainers:main Dec 11, 2024
124 checks passed
@mdelapenya mdelapenya deleted the conventional-labels branch December 11, 2024 10:01
mdelapenya added a commit to mtellis2/testcontainers-go that referenced this pull request Dec 11, 2024
* main: (234 commits)
  chore(ci): add Github labels based on PR title (testcontainers#2914)
  chore(gha): Use official setup-docker-action (testcontainers#2913)
  chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911)
  feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905)
  chore: enable implicit default logger only in testing with -v (testcontainers#2877)
  fix: container binds syntax (testcontainers#2899)
  refactor(cockroachdb): to use request driven options (testcontainers#2883)
  chore(deps): bump actions/setup-go from 5.0.0 to 5.1.0 (testcontainers#2904)
  chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.0 (testcontainers#2903)
  chore(deps): bump test-summary/action from 2.3 to 2.4 (testcontainers#2902)
  feat(wait): strategy walk (testcontainers#2895)
  feat(wait): tls strategy (testcontainers#2896)
  docs: better contribution guidelines (testcontainers#2893)
  fix(influxdb): Respect custom waitStrategy (testcontainers#2845)
  fix: only upload to sonar on ubuntu-latest (testcontainers#2891)
  fix: build artifact name properly (testcontainers#2890)
  fix: do not run sonar upload when ryuk is disabled (testcontainers#2889)
  fix: update GH actions for uploading/downloading artifacts (testcontainers#2888)
  feat(ci): Enable master moby with rootless (testcontainers#2880)
  fix(redpanda): temporary file use
  ...
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Dec 13, 2024
* main:
  feat(gcloud)!: add support to seed data when using RunBigQueryContainer (testcontainers#2523)
  security(deps): bump golang.org/x/crypto from 0.28.0 to 0.31.0 (testcontainers#2916)
  chore(ci): add Github labels based on PR title (testcontainers#2914)
  chore(gha): Use official setup-docker-action (testcontainers#2913)
  chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911)
  feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905)
  chore: enable implicit default logger only in testing with -v (testcontainers#2877)
  fix: container binds syntax (testcontainers#2899)
  refactor(cockroachdb): to use request driven options (testcontainers#2883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants